Messages in this thread | | | Date | Tue, 25 Nov 2014 15:11:14 +0100 | From | Wolfram Sang <> | Subject | Re: [PATCH v2 11/14] i2c/of: Factor out Devicetree registration code |
| |
On Mon, Nov 24, 2014 at 10:33:39PM +0000, Grant Likely wrote: > From: Pantelis Antoniou <pantelis.antoniou@konsulko.com> > > Dynamically inserting i2c client device nodes requires the use > of a single device registration method. Factor out the loop body of > of_i2c_register_devices() so that it can be called for individual > device_nodes instead of for all the children of a node. > > Note: The diff of this commit looks far more complicated than it > actually is due the indentation being changed for a large block of code. > When viewed using the diff -w flag to ignore whitespace changes it can > be seen that the change is actually quite simple. > > Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com> > [grant.likely: Made new function static and removed changes to header] > Signed-off-by: Grant Likely <grant.likely@linaro.org> > Cc: Wolfram Sang <wsa@the-dreams.de> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: linux-i2c@vger.kernel.org
Reviewed-by: Wolfram Sang <wsa@the-dreams.de>
I'd prefer that this series goes through your tree. There is still this merge conflict, but that is an easy one like I mentioned in my last review. [unhandled content-type:application/pgp-signature] | |