lkml.org 
[lkml]   [2014]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drivers:block Remove unneeded Fix me message in xsyace.c
On 11/24/2014 08:25 PM, Nicholas Krause wrote:
> Removes unneeded FIXME message related to using a hard coded value for ACE_BUS_WIDTH
> due to it needing to be 8 bits, this is wrong as this function here needs all 16 bits
> of the bus width and not just the lower or higher 16 depending on the machine's bit
> order.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> drivers/block/xsysace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/xsysace.c b/drivers/block/xsysace.c
> index c4328d9..1b807ed 100644
> --- a/drivers/block/xsysace.c
> +++ b/drivers/block/xsysace.c
> @@ -1152,7 +1152,7 @@ static void ace_free(struct device *dev)
> static int ace_probe(struct platform_device *dev)
> {
> resource_size_t physaddr = 0;
> - int bus_width = ACE_BUS_WIDTH_16; /* FIXME: should not be hard coded */
> + int bus_width = ACE_BUS_WIDTH_16;
> u32 id = dev->id;
> int irq = 0;
> int i;
>

Reviewed-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal


\
 
 \ /
  Last update: 2014-11-24 21:01    [W:0.065 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site