Messages in this thread | | | Date | Tue, 18 Nov 2014 11:29:11 +0200 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH v7 06/10] tpm: fix: move sysfs attributes to the correct place. |
| |
On Tue, Nov 11, 2014 at 03:45:09PM +0200, Jarkko Sakkinen wrote: > The sysfs attributes of the TPM device were created to the platform > device directory that owns the character device instead of placing > them correctly to the directory of the character device, > > They were also created in a racy way so that character device might > become visible before sysfs attributes become available. > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
For this patch there are at least these open items:
- Paths in Documentation/ABI/stable/sysfs-class-tpm should be updated. - I moved attributes described in the documentation to the character device sysfs-directory from platform device sysfs directory. I don't believe this is a mentionable breakage because they weren't machine readable anyway. This should be however explicitly stated in the commit message. - What should be done with PPI sysfs attributes? They are also in wrong place. - What should be done with the BIOS log? They are also in wrong place.
I think this patch is really the key change to sort out before pulling the patch set to the maintainer tree.
/Jarkko
| |