| Date | Tue, 11 Nov 2014 11:36:08 +0100 | From | Juergen Gross <> | Subject | Re: [Xen-devel] [PATCH V3 1/8] xen: Make functions static |
| |
On 11/11/2014 11:21 AM, David Vrabel wrote: > On 11/11/14 05:43, Juergen Gross wrote: >> Some functions in arch/x86/xen/p2m.c are used locally only. Make them >> static. Rearrange the functions in p2m.c to avoid forward declarations. >> >> While at it correct some style issues (long lines, use pr_warn()). > > Please don't add extra stuff like this. In general if you feel yourself > wring "while at it..." or "also..." then you need another patch.
I applied the changes only to functions I was moving, as checkpatch was complaining. Documentation says this should be avoided only when moving functions between files.
If you still think I should omit these changes I'll throw them out.
> > I also don't care about long lines if they are under 100 characters.
I do. :-)
But same again: either no style corrections or all.
Juergen
|