lkml.org 
[lkml]   [2014]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Xen-devel] [PATCH V3 3/8] xen: Delay m2p_override initialization
On Tue, Nov 11, 2014 at 10:29:32AM +0000, David Vrabel wrote:
> On 11/11/14 05:43, Juergen Gross wrote:
> > The m2p overrides are used to be able to find the local pfn for a
> > foreign mfn mapped into the domain. They are used by driver backends
> > having to access frontend data.
> >
> > As this functionality isn't used in early boot it makes no sense to
> > initialize the m2p override functions very early. It can be done
> > later without doing any harm, removing the need for allocating memory
> > via extend_brk().
> >
> > While at it make some m2p override functions static as they are only
> > used internally.
>
> Reviewed-by: David Vrabel <david.vrabel@citrix.com>
>
> But...
>
> > static struct page *m2p_find_override(unsigned long mfn)
> > {
> > unsigned long flags;
> > - struct list_head *bucket = &m2p_overrides[mfn_hash(mfn)];
> > + struct list_head *bucket;
> > struct page *p, *ret;
>
>
> if (unlikely(!m2p_overrides))
> return NULL;
>
> Would be preferred,

Aye,

Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>
> David


\
 
 \ /
  Last update: 2014-11-12 20:21    [W:0.047 / U:11.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site