lkml.org 
[lkml]   [2014]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 04/10] tpm: rename chip->dev to chip->pdev
On Mon, Nov 10, 2014 at 02:49:48PM +0200, Jarkko Sakkinen wrote:
> Rename chip->dev to chip->pdev to make it explicit that this not the
> character device but actually represents the platform device.

I don't really have time to take a detailed look at this for a few
weeks, but I like this entire patch set.


> - if (try_module_get(pos->dev->driver->owner)) {
> + if (try_module_get(pos->pdev->driver->owner)) {
> chip = pos;
> break;

Yes, this needs to be pdev

> if (test_and_set_bit(0, &chip->is_open)) {
> - dev_dbg(chip->dev, "Another process owns this TPM\n");
> + dev_dbg(chip->pdev, "Another process owns this TPM\n");
> return -EBUSY;

This should be moved to the class dev, ie it should ultimately say dev_dbg(&chip->dev,..

Similar comments all over the place.

Jason


\
 
 \ /
  Last update: 2014-11-10 19:01    [W:0.127 / U:0.988 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site