Messages in this thread | | | Date | Mon, 10 Nov 2014 10:45:11 -0700 | From | Jason Gunthorpe <> | Subject | Re: [PATCH v6 04/10] tpm: rename chip->dev to chip->pdev |
| |
On Mon, Nov 10, 2014 at 02:49:48PM +0200, Jarkko Sakkinen wrote: > Rename chip->dev to chip->pdev to make it explicit that this not the > character device but actually represents the platform device.
I don't really have time to take a detailed look at this for a few weeks, but I like this entire patch set.
> - if (try_module_get(pos->dev->driver->owner)) { > + if (try_module_get(pos->pdev->driver->owner)) { > chip = pos; > break;
Yes, this needs to be pdev
> if (test_and_set_bit(0, &chip->is_open)) { > - dev_dbg(chip->dev, "Another process owns this TPM\n"); > + dev_dbg(chip->pdev, "Another process owns this TPM\n"); > return -EBUSY;
This should be moved to the class dev, ie it should ultimately say dev_dbg(&chip->dev,..
Similar comments all over the place.
Jason
| |