lkml.org 
[lkml]   [2014]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 10/10] tpm: TPM 2.0 sysfs attributes
On Mon, Nov 10, 2014 at 02:49:54PM +0200, Jarkko Sakkinen wrote:

> if (len > le32_to_cpu(cca->cmd_size)) {
> - dev_err(chip->dev,
> + dev_err(&chip->dev,

Is this out of sequence in the patch series?

>
> rc = tpm2_do_selftest(chip);
> - if (rc) {
> - dev_err(dev, "self-test failed\n");
> + if (rc)
> return rc;
> - }
>
> rc = tpm_chip_register(chip);
> - if (rc) {
> - dev_err(dev, "registering the chip failed\n");
> + if (rc)
> return rc;
> - }

Ditto.

Also, just:

return tpm_chip_register(chip);

Jason


\
 
 \ /
  Last update: 2014-11-10 19:41    [W:0.113 / U:3.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site