lkml.org 
[lkml]   [2014]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] block: wrong return value
Date
while compiling integer err was showing as a set but unused variable.
elevator_init_fn can be either cfq_init_queue or deadline_init_queue
or noop_init_queue.
all three of these functions are returning -ENOMEM if they fail to
allocate the queue.
so we should actually be returning the error code rather than
returning 0 always.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---

hi,
if my understanding was wrong and if it is indeed a case of unusued variable,
then please discard this patch.

block/elevator.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/elevator.c b/block/elevator.c
index 24c28b6..7560417 100644
--- a/block/elevator.c
+++ b/block/elevator.c
@@ -184,7 +184,7 @@ static void elevator_release(struct kobject *kobj)
int elevator_init(struct request_queue *q, char *name)
{
struct elevator_type *e = NULL;
- int err;
+ int err = 0;

/*
* q->sysfs_lock must be held to provide mutual exclusion between
@@ -229,7 +229,7 @@ int elevator_init(struct request_queue *q, char *name)
}

err = e->ops.elevator_init_fn(q, e);
- return 0;
+ return err;
}
EXPORT_SYMBOL(elevator_init);

--
1.8.1.2


\
 
 \ /
  Last update: 2014-10-23 16:01    [W:0.053 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site