Messages in this thread Patch in this message | | | From | Hannes Reinecke <> | Subject | [PATCH] block: misplaced rq_complete tracepoint | Date | Wed, 1 Oct 2014 14:32:31 +0200 |
| |
The rq_complete tracepoint was never issued for empty requests, causing the resulting blktrace information to never show any completion for those request.
Signed-off-by: Hannes Reinecke <hare@suse.de> --- block/blk-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/blk-core.c b/block/blk-core.c index 3aff9f5..eb05abf 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -2414,11 +2414,11 @@ bool blk_update_request(struct request *req, int error, unsigned int nr_bytes) { int total_bytes; + trace_block_rq_complete(req->q, req, nr_bytes); + if (!req->bio) return false; - trace_block_rq_complete(req->q, req, nr_bytes); - /* * For fs requests, rq is just carrier of independent bio's * and each partial completion should be handled separately. -- 1.8.5.2
| |