Messages in this thread | | | Date | Fri, 31 Jan 2014 02:46:08 -0800 (PST) | From | David Rientjes <> | Subject | Re: [PATCH v4 1/2] mm: add kstrimdup function |
| |
On Fri, 31 Jan 2014, Pavel Machek wrote:
> > kstrimdup will duplicate and trim spaces from the passed in > > null terminated string. This is useful for strings coming from > > sysfs that often include trailing whitespace due to user input. > > Is it good idea? I mean "\n\n/foo bar baz" is valid filename in > unix. This is kernel interface, it is not meant to be too user > friendly...
v6 of this patchset carries your ack of the patch that uses this for /sys/debug/resume, so are you disagreeing we need this support at all or that it shouldn't be the generic sysfs write behavior? If the latter, I agree, and the changelog could be improved to specify what writes we actually care about.
| |