Messages in this thread | | | Date | Fri, 31 Jan 2014 11:32:32 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH v4 1/2] mm: add kstrimdup function |
| |
On Wed 2014-01-29 15:48:23, Sebastian Capella wrote: > kstrimdup will duplicate and trim spaces from the passed in > null terminated string. This is useful for strings coming from > sysfs that often include trailing whitespace due to user input.
Is it good idea? I mean "\n\n/foo bar baz" is valid filename in unix. This is kernel interface, it is not meant to be too user friendly... Pavel
> +char *kstrimdup(const char *s, gfp_t gfp) > +{ > + char *ret = kstrdup(skip_spaces(s), gfp); > + > + if (ret) > + strim(ret); > + return ret; > +} > +EXPORT_SYMBOL(kstrimdup); > + > +/** > * kmemdup - duplicate region of memory > * > * @src: memory region to duplicate
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |