Messages in this thread | | | Date | Thu, 16 Jan 2014 10:42:01 +0100 | From | Olaf Hering <> | Subject | Re: [PATCH V2 1/1] Drivers: hv: Implement the file copy service |
| |
On Tue, Jan 14, K. Y. Srinivasan wrote:
> +enum hv_fcopy_op { > + START_FILE_COPY = 0, > + WRITE_TO_FILE, > + COMPLETE_FCOPY, > + CANCEL_FCOPY, > +}; > + > +struct hv_fcopy_hdr { > + enum hv_fcopy_op operation; > + uuid_le service_id0; /* currently unused */ > + uuid_le service_id1; /* currently unused */ > +} __attribute__((packed));
Is enum a fixed size? This struct is used in other structs, so I wonder what will happen to the kernel/user protocol if any of that changes. Or with a 64bit kernel and 32bit daemon. Maybe operation should be __u32?
Olaf
| |