lkml.org 
[lkml]   [2014]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH V2 1/1] Drivers: hv: Implement the file copy service
    Date


    > -----Original Message-----
    > From: Olaf Hering [mailto:olaf@aepfle.de]
    > Sent: Thursday, January 16, 2014 1:42 AM
    > To: KY Srinivasan
    > Cc: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org;
    > devel@linuxdriverproject.org; apw@canonical.com; jasowang@redhat.com
    > Subject: Re: [PATCH V2 1/1] Drivers: hv: Implement the file copy service
    >
    > On Tue, Jan 14, K. Y. Srinivasan wrote:
    >
    > > +enum hv_fcopy_op {
    > > + START_FILE_COPY = 0,
    > > + WRITE_TO_FILE,
    > > + COMPLETE_FCOPY,
    > > + CANCEL_FCOPY,
    > > +};
    > > +
    > > +struct hv_fcopy_hdr {
    > > + enum hv_fcopy_op operation;
    > > + uuid_le service_id0; /* currently unused */
    > > + uuid_le service_id1; /* currently unused */
    > > +} __attribute__((packed));
    >
    > Is enum a fixed size? This struct is used in other structs, so I wonder
    > what will happen to the kernel/user protocol if any of that changes. Or
    > with a 64bit kernel and 32bit daemon. Maybe operation should be __u32?

    I will check and make the necessary changes.

    Thank you,

    K. Y
    >
    >
    > Olaf
    \
     
     \ /
      Last update: 2014-01-16 17:41    [W:3.101 / U:0.540 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site