Messages in this thread | | | Date | Wed, 25 Sep 2013 19:32:50 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] checkpatch: Add test for #defines of ARCH_HAS_<foo> |
| |
On Wed, 25 Sep 2013 19:00:54 -0700 Joe Perches <joe@perches.com> wrote:
> +# Use of __ARCH_HAS_<FOO> or ARCH_HAVE_<BAR> is wrong. > + if ($line =~ /\+\s*#\s*define\s+((?:__)?ARCH_(?:HAS|HAVE)\w*)\b/) { > + ERROR("DEFINE_ARCH_HAS", > + "#define of '$1' is wrong - use Kconfig variables or standard guards instead\n" . $herecurr); > + } > +
Perhaps we can provide people with a bit more help than that. http://www.kernelhub.org/?msg=334759&p=2 would suit (gad, google updates fast!) or copy-n-paste into Documentation/wherever and refer to that?
| |