Messages in this thread | | | Subject | Re: [PATCH] checkpatch: Add test for #defines of ARCH_HAS_<foo> | From | Joe Perches <> | Date | Wed, 25 Sep 2013 19:40:26 -0700 |
| |
On Wed, 2013-09-25 at 19:32 -0700, Andrew Morton wrote: > On Wed, 25 Sep 2013 19:00:54 -0700 Joe Perches <joe@perches.com> wrote: > > > +# Use of __ARCH_HAS_<FOO> or ARCH_HAVE_<BAR> is wrong. > > + if ($line =~ /\+\s*#\s*define\s+((?:__)?ARCH_(?:HAS|HAVE)\w*)\b/) { > > + ERROR("DEFINE_ARCH_HAS", > > + "#define of '$1' is wrong - use Kconfig variables or standard guards instead\n" . $herecurr); > > + } > > + > > Perhaps we can provide people with a bit more help than that. > http://www.kernelhub.org/?msg=334759&p=2 would suit (gad, google > updates fast!) or copy-n-paste into Documentation/wherever and refer to > that? >
Maybe the fancy lkml.kernel.org link:
http://lkml.kernel.org/r/CA+55aFycQ9XJvEOsiM3txHL5bjUc8CeKWJNR_H+MiicaddB42Q@mail.gmail.com
as that might be more long-term stable.
Will kernel.org ever store all the lkml emails so it doesn't have to reference outside links?
| |