Messages in this thread | | | From | Lucas De Marchi <> | Date | Tue, 13 Aug 2013 20:34:58 -0300 | Subject | Re: [PATCH 0/3] module: Allow parameters without arguments |
| |
On Tue, Aug 13, 2013 at 6:02 PM, Steven Rostedt <rostedt@goodmis.org> wrote: > Rusty, > > I'm looking at porting my "enable tracepoints in module load" patches > and one of the comments you gave me (long ago) was to not have: > > trace_foo=1 > > but to just have: > > trace_foo > > as a parameter name. I went and implemented this but discovered that the > functions that allow no arguments are hard coded in the params.c file. > > I changed this to allow other "set" functions to be given no arguments, > and even noticed that a few already exist in the kernel. So I'm sending > you this patch set that implements a modification to the parameter > parsing to allow other kernel_param_ops to not bother with arguments > passed in. > > What do you think?
so in kcmdline we would have modulename.param instead of modulename.param=1?
I guess we need to update kmod then, because currently we ignore and treat this case as a wrong token. From a quick look, allowing it in kmod would be as simple as removing a condition check.
Lucas De Marchi
| |