Messages in this thread | | | Date | Tue, 13 Aug 2013 20:17:02 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH 0/3] module: Allow parameters without arguments |
| |
On Tue, 13 Aug 2013 20:34:58 -0300 Lucas De Marchi <lucas.de.marchi@gmail.com> wrote:
> so in kcmdline we would have modulename.param instead of modulename.param=1? > > I guess we need to update kmod then, because currently we ignore and > treat this case as a wrong token. From a quick look, allowing it in > kmod would be as simple as removing a condition check. > > Lucas De Marchi
Note, both will still work. And it didn't change much. Today, anything that uses "module_param()" with bool type (a quick git grep shows 570 users), already do not require a value.
Randomly looking at one... drivers/input/mouse/synaptics_i2c.c, you can just do:
insmod synaptics_i2c.ko no_filter
no need to add a "=1" to that.
But anything else will still require a value. I just want to allow other parameters that act like a boolean to not require one.
-- Steve
| |