Messages in this thread | | | Date | Tue, 2 Jul 2013 12:57:15 +0200 | Subject | Re: [PATCH] include/asm-generic/io.h: add dummy fuctions to support 'COMPILE_TEST' in 'asm-generic'. | From | Geert Uytterhoeven <> |
| |
On Tue, Jul 2, 2013 at 10:00 AM, Chen Gang <gang.chen@asianux.com> wrote: > On 07/02/2013 03:19 PM, Geert Uytterhoeven wrote: >> On Tue, Jul 2, 2013 at 4:13 AM, Chen Gang <gang.chen@asianux.com> wrote: >>> > 'asm-generic' need provide necessary configuration checking, if can't >>> > pass checking, 'asm-generic' shouldn't implement it. >>> > >>> > For 'COMPILE_TEST', according to its help contents, 'asm-generic' need >>> > let it pass configuration checking, and provide related dummy contents >>> > for it. >>> > >>> > Part of 'COMPLE_TEST' help contents in "init/Kconfig": >>> > >>> > "...Despite they cannot be loaded there (or even when they load they cannot be used due to missing HW support)..." >>> > >>> > >>> > Signed-off-by: Chen Gang <gang.chen@asianux.com> >> NAKed-by: Geert Uytterhoeven <geert@linux-m68k.org> >> >> Please don't clutter the code with checks for CONFIG_COMPILE_TEST. > > Do you mean: 'asm-generic' should not support 'COMPILE_TEST' (the > platform should not support 'COMPILE_TEST") ? > > Or you mean: 'COMPILE_TEST' should not exist in kernel ?
I mean that COMPILE_TEST should exist in Kconfig files only. It's only meant to have more compile coverage, not to "fix" (through #ifdef) more code to make it compile.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |