Messages in this thread | | | Date | Tue, 02 Jul 2013 16:00:14 +0800 | From | Chen Gang <> | Subject | Re: [PATCH] include/asm-generic/io.h: add dummy fuctions to support 'COMPILE_TEST' in 'asm-generic'. |
| |
On 07/02/2013 03:19 PM, Geert Uytterhoeven wrote: > On Tue, Jul 2, 2013 at 4:13 AM, Chen Gang <gang.chen@asianux.com> wrote: >> > 'asm-generic' need provide necessary configuration checking, if can't >> > pass checking, 'asm-generic' shouldn't implement it. >> > >> > For 'COMPILE_TEST', according to its help contents, 'asm-generic' need >> > let it pass configuration checking, and provide related dummy contents >> > for it. >> > >> > Part of 'COMPLE_TEST' help contents in "init/Kconfig": >> > >> > "...Despite they cannot be loaded there (or even when they load they cannot be used due to missing HW support)..." >> > >> > >> > Signed-off-by: Chen Gang <gang.chen@asianux.com> > NAKed-by: Geert Uytterhoeven <geert@linux-m68k.org> > > Please don't clutter the code with checks for CONFIG_COMPILE_TEST.
Do you mean: 'asm-generic' should not support 'COMPILE_TEST' (the platform should not support 'COMPILE_TEST") ?
Or you mean: 'COMPILE_TEST' should not exist in kernel ?
Can we use 'asm-default' instead of 'asm-generic', since "if HW support, it will provide default value, or it will provide nothing" ?
Thanks. -- Chen Gang
| |