Messages in this thread Patch in this message | | | Date | Tue, 02 Jul 2013 00:29:56 +0800 | From | Zhang Yanfei <> | Subject | [PATCH] mm, slab: Drop unnecessary slabp->inuse < cachep->num test |
| |
From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
In function cache_alloc_refill, we have used BUG_ON to ensure that slabp->inuse is less than cachep->num before the while test. And in the while body, we do not change the value of slabp->inuse and cachep->num, so it is not necessary to test if slabp->inuse < cachep->num test for every loop.
Signed-off-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com> --- mm/slab.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/mm/slab.c b/mm/slab.c index 8ccd296..c2076c2 100644 --- a/mm/slab.c +++ b/mm/slab.c @@ -3004,7 +3004,7 @@ retry: */ BUG_ON(slabp->inuse >= cachep->num); - while (slabp->inuse < cachep->num && batchcount--) { + while (batchcount--) { STATS_INC_ALLOCED(cachep); STATS_INC_ACTIVE(cachep); STATS_SET_HIGH(cachep); -- 1.7.1
| |