lkml.org 
[lkml]   [2013]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [ 044/184] ALSA: ice1712: Initialize card->private_data
Hi Ben,

On Fri, Jun 07, 2013 at 04:48:58AM +0100, Ben Hutchings wrote:
> > From: Sean Connor <sconnor004@allyinics.org>
> >
> > commit 69a4cfdd444d1fe5c24d29b3a063964ac165d2cd upstream.
> >
> > Set card->private_data in snd_ice1712_create for fixing NULL
> > dereference in snd_ice1712_remove().
>
> This bug appears to have been introduced in Linux 3.8 and doesn't need
> fixing in 2.6.32.

Ah indeed that's true. Does it harm to have it or not ? because I'm
still seeing a number of places where we have this in the driver :

struct snd_ice1712 *ice = ac97->private_data;

I'd like to be sure that no other function risks to dereference the
same pointer. Also, I'm noting that 3.0/3.4 have this fix, while 3.2
does not. So I'm hesitant what to do with this patch.

Thanks,
Willy



\
 
 \ /
  Last update: 2013-06-07 08:01    [W:0.140 / U:2.720 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site