lkml.org 
[lkml]   [2013]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [ 044/184] ALSA: ice1712: Initialize card->private_data
From
Date
On Tue, 2013-06-04 at 19:22 +0200, Willy Tarreau wrote:
> 2.6.32-longterm review patch. If anyone has any objections, please let me know.
>
> ------------------
> properly
>
> From: Sean Connor <sconnor004@allyinics.org>
>
> commit 69a4cfdd444d1fe5c24d29b3a063964ac165d2cd upstream.
>
> Set card->private_data in snd_ice1712_create for fixing NULL
> dereference in snd_ice1712_remove().

This bug appears to have been introduced in Linux 3.8 and doesn't need
fixing in 2.6.32.

Ben.

> Signed-off-by: Sean Connor <sconnor004@allyinics.org>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Willy Tarreau <w@1wt.eu>
> ---
> sound/pci/ice1712/ice1712.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/pci/ice1712/ice1712.c b/sound/pci/ice1712/ice1712.c
> index d74033a..95496ae 100644
> --- a/sound/pci/ice1712/ice1712.c
> +++ b/sound/pci/ice1712/ice1712.c
> @@ -2574,6 +2574,8 @@ static int __devinit snd_ice1712_create(struct snd_card *card,
> snd_ice1712_proc_init(ice);
> synchronize_irq(pci->irq);
>
> + card->private_data = ice;
> +
> err = pci_request_regions(pci, "ICE1712");
> if (err < 0) {
> kfree(ice);

--
Ben Hutchings
Theory and practice are closer in theory than in practice.
- John Levine, moderator of comp.compilers
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2013-06-07 06:41    [W:0.661 / U:1.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site