lkml.org 
[lkml]   [2013]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Qemu-devel] [PATCH] virtio-net: put virtio net header inline with data
On 06/06/2013 03:09 PM, Dave Jones wrote:
> On Thu, Jun 06, 2013 at 02:59:44PM -0500, Jesse Larrew wrote:
>
> > > pr_debug("%s: xmit %p %pM\n", vi->dev->name, skb, dest);
> > > + if (vi->mergeable_rx_bufs)
> > > + hdr_len = sizeof hdr->mhdr;
> > > + else
> > > + hdr_len = sizeof hdr->hdr;
> >
> > All conditionals need braces.
>
> Documentation/CodingStyle disagrees:
>
> "Do not unnecessarily use braces where a single statement will do."
>
> Dave
>

Ah, yes. This is kernel code. My mistake. :)

Jesse Larrew
Software Engineer, KVM Team
IBM Linux Technology Center
Phone: (512) 973-2052 (T/L: 363-2052)
jlarrew@linux.vnet.ibm.com



\
 
 \ /
  Last update: 2013-06-06 23:21    [W:0.112 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site