lkml.org 
[lkml]   [2013]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Qemu-devel] [PATCH] virtio-net: put virtio net header inline with data
On Thu, Jun 06, 2013 at 02:59:44PM -0500, Jesse Larrew wrote:

> > pr_debug("%s: xmit %p %pM\n", vi->dev->name, skb, dest);
> > + if (vi->mergeable_rx_bufs)
> > + hdr_len = sizeof hdr->mhdr;
> > + else
> > + hdr_len = sizeof hdr->hdr;
>
> All conditionals need braces.

Documentation/CodingStyle disagrees:

"Do not unnecessarily use braces where a single statement will do."

Dave


\
 
 \ /
  Last update: 2013-06-06 22:41    [W:0.089 / U:2.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site