lkml.org 
[lkml]   [2013]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Modify UEFI anti-bricking code
On 06/05/2013 08:59 AM, Matt Fleming wrote:
> + * There still isn't enough room, so return an error
> + */
> + if (remaining_size - size < 5120)
> + return EFI_OUT_OF_RESOURCES;
> + }

Please don't open-code the constant 5120 in this case. We may easily
run into a system which needs, say, 7K, and it is error-prone to just
replace numbers.

-hpa




\
 
 \ /
  Last update: 2013-06-05 23:01    [W:0.119 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site