Messages in this thread | | | Date | Wed, 05 Jun 2013 13:19:12 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] Modify UEFI anti-bricking code |
| |
On 06/05/2013 08:59 AM, Matt Fleming wrote: > + * There still isn't enough room, so return an error > + */ > + if (remaining_size - size < 5120) > + return EFI_OUT_OF_RESOURCES; > + }
Please don't open-code the constant 5120 in this case. We may easily run into a system which needs, say, 7K, and it is error-prone to just replace numbers.
-hpa
| |