lkml.org 
[lkml]   [2013]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] Modify UEFI anti-bricking code
    Date
    On Thu, 2013-06-06 at 13:05 +0800, joeyli wrote:

    > + if (!(attributes & EFI_VARIABLE_NON_VOLATILE))
    > + return EFI_OUT_OF_RESOURCES;

    I'd move this up to the top of the function, and just return 0 - there's
    no risk of the firmware causing problems if it's a volatile variable, so
    we should probably just pass it down to the firmware and return an error
    from there.

    --
    Matthew Garrett | mjg59@srcf.ucam.org
    \
     
     \ /
      Last update: 2013-06-06 08:21    [W:3.715 / U:0.280 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site