Messages in this thread | | | From | Matthew Garrett <> | Subject | Re: [PATCH] Modify UEFI anti-bricking code | Date | Thu, 6 Jun 2013 05:42:01 +0000 |
| |
On Thu, 2013-06-06 at 13:05 +0800, joeyli wrote:
> + if (!(attributes & EFI_VARIABLE_NON_VOLATILE)) > + return EFI_OUT_OF_RESOURCES;
I'd move this up to the top of the function, and just return 0 - there's no risk of the firmware causing problems if it's a volatile variable, so we should probably just pass it down to the firmware and return an error from there.
-- Matthew Garrett | mjg59@srcf.ucam.org
| |