Messages in this thread | | | Date | Sat, 29 Jun 2013 09:20:16 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 0/3] static keys: fix test/set races |
| |
* jbaron@akamai.com <jbaron@akamai.com> wrote:
> Hi, > > As pointed out by Andi Kleen, some static key users can be racy because they > check the value of the key->enabled, and then subsequently update the branch > direction. A number of call sites have 'higher' level locking that avoids this > race, but the usage in the scheduler features does not. See: > http://lkml.indiana.edu/hypermail/linux/kernel/1304.2/01655.html
But that's not an issue at all - switching the scheduler features is for development and debugging only, and in some cases higher level locking would be needed to solve it 'properly', beyond what the keys API could give ...
So this is pretty pointless, sorry, please don't complicate this facility.
Thanks,
Ingo
| |