Messages in this thread | | | Date | Mon, 30 Jun 2014 18:36:39 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH 0/3] static keys: fix test/set races |
| |
On Mon, 30 Jun 2014 17:43:50 -0400 Jason Baron <jbaron@akamai.com> wrote:
> Hi Steve, > > I took a closer look at this, and I'm thinking now that its simpler to > just take the &inode->i_mutex in sched_feat_write(), surrounding the > test/set jump_label call. It should be about 3 lines :)
Smaller patches are always nice.
> > I started re-working this with the patches in this series and it just > seemed like a lot of code for only 1 current use-case. (The udp case > doesn't appear to disable the branch and thus is not racy.) > > So I've swung back to what Ingo originally said - I can test/post the > suggested 3-line patch, unless there are other thoughts...
Well, the final decision lies with Peter and Ingo. I only noticed it while cleaning out my inbox and didn't want it to be forgotten.
-- Steve
| |