Messages in this thread | | | Date | Thu, 20 Jun 2013 16:26:25 +0200 | From | Ralf Baechle <> | Subject | Re: [PATCH] MIPS: Fix OCTEON BUG() warnings a different way. |
| |
On Wed, Jun 19, 2013 at 03:04:28PM -0700, David Daney wrote:
> Signed-off-by: David Daney <david.daney@cavium.com>
I replaced my fix with your fix but left he direct inclusion of <linux/bug.h>.
Let as homework for a later point: make BUG() invoke unreachable() if CONFIG_BUG is diabled, something like that. This will improve code generation for GCC 4.5+ but for older compilers unreachable() is defined as do { } while (1) so will emit extra code.
Thanks,
Ralf
| |