| From | Bjorn Helgaas <> | Date | Thu, 9 May 2013 12:43:29 -0700 | Subject | Re: [PATCH 04/27] block: Convert integrity to bvec_alloc_bs() |
| |
On Tue, Feb 19, 2013 at 4:22 PM, Kent Overstreet <koverstreet@google.com> wrote:
> diff --git a/fs/bio-integrity.c b/fs/bio-integrity.c > index 94fa1c5..8c4c604 100644 > --- a/fs/bio-integrity.c > +++ b/fs/bio-integrity.c > ... > @@ -766,13 +733,14 @@ void bioset_integrity_free(struct bio_set *bs) > { > if (bs->bio_integrity_pool) > mempool_destroy(bs->bio_integrity_pool); > + > + if (bs->bvec_integrity_pool) > + mempool_destroy(bs->bio_integrity_pool);
I think this is a copy-and-paste error that results in using bs->bio_integrity_pool after it has been freed. Found by Coverity (CID 1020654).
> } > EXPORT_SYMBOL(bioset_integrity_free);
|