Messages in this thread | | | Date | Tue, 26 Mar 2013 11:11:06 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 26/27] block: Add an explicit bio flag for bios that own their bvec |
| |
On Tue, 19 Feb 2013 16:22:40 -0800 Kent Overstreet <koverstreet@google.com> wrote:
> This is for the new bio splitting code. When we split a bio, if the > split occured on a bvec boundry we reuse the bvec for the new bio. But > that means bio_free() can't free it, hence the explicit flag. > > --- a/include/linux/blk_types.h > +++ b/include/linux/blk_types.h > @@ -117,6 +117,7 @@ struct bio { > * BIO_POOL_IDX() > */ > #define BIO_RESET_BITS 12 > +#define BIO_OWNS_VEC 12 /* bio_free() should free bvec */ > > #define bio_flagged(bio, flag) ((bio)->bi_flags & (1 << (flag)))
The BIO_OWNS_VEC definition seems to be in the wrong place - it should be grouped with the "bio flags" group above?
| |