lkml.org 
[lkml]   [2013]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 29.5/32] blk-throttle: add throtl_qnode for dispatch fairness
On Mon, May 06, 2013 at 12:00:06PM -0400, Vivek Goyal wrote:
> On Fri, May 03, 2013 at 05:50:44PM -0700, Tejun Heo wrote:
>
> [..]
> > + * qnode_on_self is used when bios are directly queued to this
> > + * throtl_grp so that local bios compete fairly with bios
> > + * dispatched from children. qnode_on_parent is used when bios are
> > + * dispatched from this throtl_grp into its parent and will compete
> > + * with the sibling qnode_on_parents and the parent's
> > + * qnode_on_self.
> > + */
> > + struct throtl_qnode qnode_on_self;
> > + struct throtl_qnode qnode_on_parent;
>
> Do we need one throtl_qnode for each IO dir (read/write) so that we can
> queue up the right direction throtl_node in right sq->queued[rw].

Yes, we do. Thanks for spotting it. Will post an updated version soon.

--
tejun


\
 
 \ /
  Last update: 2013-05-06 21:01    [W:0.944 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site