Messages in this thread | | | Date | Fri, 3 May 2013 17:53:58 -0700 | From | Tejun Heo <> | Subject | Re: [PATCH 29.5/32] blk-throttle: add throtl_qnode for dispatch fairness |
| |
On Fri, May 03, 2013 at 05:50:44PM -0700, Tejun Heo wrote: .... > +static struct bio *throtl_pop_queued(struct list_head *queued, > + struct throtl_grp **tg_to_put) > +{ > + struct throtl_qnode *qn = list_first_entry(queued, struct throtl_qnode, node); > + struct bio *bio; > + > + if (list_empty(queued)) > + return NULL; > + > + bio = bio_list_pop(&qn->bios); > + WARN_ON_ONCE(!bio); > + > + if (bio_list_empty(&qn->bios)) { > + list_del_init(&qn->node); > + if (tg_to_put) > + *tg_to_put = qn->tg; > + else > + blkg_put(tg_to_blkg(tg_to_put));
Oops, this should have been
blkg_put(tg_to_blkg(qn->tg));
Thanks.
-- tejun
| |