lkml.org 
[lkml]   [2013]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 29.5/32] blk-throttle: add throtl_qnode for dispatch fairness
    On Fri, May 03, 2013 at 05:50:44PM -0700, Tejun Heo wrote:
    ....
    > +static struct bio *throtl_pop_queued(struct list_head *queued,
    > + struct throtl_grp **tg_to_put)
    > +{
    > + struct throtl_qnode *qn = list_first_entry(queued, struct throtl_qnode, node);
    > + struct bio *bio;
    > +
    > + if (list_empty(queued))
    > + return NULL;
    > +
    > + bio = bio_list_pop(&qn->bios);
    > + WARN_ON_ONCE(!bio);
    > +
    > + if (bio_list_empty(&qn->bios)) {
    > + list_del_init(&qn->node);
    > + if (tg_to_put)
    > + *tg_to_put = qn->tg;
    > + else
    > + blkg_put(tg_to_blkg(tg_to_put));

    Oops, this should have been

    blkg_put(tg_to_blkg(qn->tg));

    Thanks.

    --
    tejun


    \
     
     \ /
      Last update: 2013-05-04 03:21    [W:4.653 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site