Messages in this thread | | | Date | Wed, 29 May 2013 17:08:15 -0500 | From | Guy Streeter <> | Subject | Re: [PATCH] audit: wait_for_auditd() should use TASK_UNINTERRUPTIBLE |
| |
On 05/29/2013 04:59 PM, Andrew Morton wrote: > On Fri, 24 May 2013 19:39:25 +0200 Oleg Nesterov <oleg@redhat.com> wrote: > >> audit_log_start() does wait_for_auditd() in a loop until >> audit_backlog_wait_time passes or audit_skb_queue has a room. >> >> If signal_pending() is true this becomes a busy-wait loop, >> schedule() in TASK_INTERRUPTIBLE won't block. > > And that's game over for a uniprocessor non-preempt machine, yes? > >> Reported-by: Guy Streeter <streeter@redhat.com> > > And what did Guy report? "that looks screwy"? "my machine locked up"? >
Our customer was in fact running a uniprocessor machine, and they reported a system hang. --Guy
| |