lkml.org 
[lkml]   [2013]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] audit: wait_for_auditd() should use TASK_UNINTERRUPTIBLE
On 05/29, Andrew Morton wrote:
>
> On Fri, 24 May 2013 19:39:25 +0200 Oleg Nesterov <oleg@redhat.com> wrote:
>
> > audit_log_start() does wait_for_auditd() in a loop until
> > audit_backlog_wait_time passes or audit_skb_queue has a room.
> >
> > If signal_pending() is true this becomes a busy-wait loop,
> > schedule() in TASK_INTERRUPTIBLE won't block.
>
> And that's game over for a uniprocessor non-preempt machine, yes?

If this task is rt, yes. Otherwise schedule() still does pick_next_task()
but this is obviously bad anyway. So I fully agree with "Cc: stable" you
added.

> > Reported-by: Guy Streeter <streeter@redhat.com>
>
> And what did Guy report? "that looks screwy"? "my machine locked up"?

He also investigated the problem and provided the detailed explanation ;)

Oleg.



\
 
 \ /
  Last update: 2013-05-31 19:41    [W:0.605 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site