Messages in this thread | | | Date | Mon, 27 May 2013 14:28:39 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [RFC PATCHv4 4/6] clocksource: TI-Nspire timer support |
| |
On Mon, 27 May 2013, Linus Walleij wrote: > > +static void zevio_timer_set_mode(enum clock_event_mode mode, > > + struct clock_event_device *dev) > > +{ > > + unsigned long flags; > > + struct zevio_timer *timer = container_of(dev, > > + struct zevio_timer, > > + clkevt); > > + > > + local_irq_save(flags); > > + > > + switch (mode) { > > + case CLOCK_EVT_MODE_PERIODIC: > > + /* Unsupported */ > > + break; > > + case CLOCK_EVT_MODE_RESUME: > > + case CLOCK_EVT_MODE_ONESHOT: > > + /* Enable timer interrupts */ > > + writel(TIMER_INTR_MSK, timer->interrupt_regs + IO_INTR_MSK); > > + writel(TIMER_INTR_ALL, timer->interrupt_regs + IO_INTR_ACK); > > + dev->mode = mode; > > + break; > > + case CLOCK_EVT_MODE_SHUTDOWN: > > + case CLOCK_EVT_MODE_UNUSED: > > + /* Disable timer interrupts */ > > + writel(0, timer->interrupt_regs + IO_INTR_MSK); > > + writel(TIMER_INTR_ALL, timer->interrupt_regs + IO_INTR_ACK); > > + /* Stop timer */ > > + writel(CNTL_STOP_TIMER, timer->timer1 + IO_CONTROL); > > + dev->mode = mode; > > + break; > > + } > > Surely both the compiler and checkpatch is complaining that this > switch does not contain a default: clause?
Well, if you have a switch with an enum, the compiler complains if you do not have a case for each enum value and the above has all enum values covered AFAICT. :)
Thanks,
tglx
| |