lkml.org 
[lkml]   [2013]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCHv4 4/6] clocksource: TI-Nspire timer support
From
Date

On 27/05/2013, at 8:53 PM, Linus Walleij <linus.walleij@linaro.org> wrote:

> On Sat, May 25, 2013 at 1:08 PM, Daniel Tang <dt.tangr@gmail.com> wrote:
>
>> Add clocksource and clockevent driver for the TI-Nspire.
>>
>> Signed-off-by: Daniel Tang <dt.tangr@gmail.com>
>
> This is *much* improved :-D

Awesome!

>> + /* Disable timer interrupts */
>> + writel(0, timer->interrupt_regs + IO_INTR_MSK);
>> + writel(TIMER_INTR_ALL, timer->interrupt_regs + IO_INTR_ACK);
>> + /* Stop timer */
>> + writel(CNTL_STOP_TIMER, timer->timer1 + IO_CONTROL);
>> + dev->mode = mode;
>> + break;
>> + }
>
> Surely both the compiler and checkpatch is complaining that this
> switch does not contain a default: clause?

Neither in fact. checkpatch.pl gives me a all-clear.

But, I'll clean it up anyway - seems cleaner that way XD.

>
> If you fix this you can add my:
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Yours,
> Linus Walleij

Cheers,
Daniel Tang

\
 
 \ /
  Last update: 2013-05-27 13:21    [W:0.061 / U:0.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site