Messages in this thread | | | Date | Fri, 3 May 2013 11:10:31 +0900 | From | Takuya Yoshikawa <> | Subject | Re: [PATCH v4 2/6] KVM: x86: introduce memslot_set_lpage_disallowed |
| |
On Sat, 27 Apr 2013 11:13:18 +0800 Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com> wrote:
> It is used to set disallowed large page on the specified level, can be > used in later patch > > Signed-off-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com> > --- > arch/x86/kvm/x86.c | 53 ++++++++++++++++++++++++++++++++++----------------- > 1 files changed, 35 insertions(+), 18 deletions(-) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 91dd9f4..52b4e97 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -6917,12 +6917,45 @@ void kvm_arch_free_memslot(struct kvm_memory_slot *free, > } > } > > +static void memslot_set_lpage_disallowed(struct kvm_memory_slot *slot, > + unsigned long npages, > + int lpage_size, int lpages)
What this function does is to disable large page support for this slot as can be seen in the comment below.
Since setting lpage_info to something ("disallowed" ?) is an implementation detail, we'd better hide such a thing from the function name.
Taking into account that we have "kvm_largepages_enabled()", something like disable_largepages_memslot() may be a candidate.
But I want to see suggestions from others as well.
Takuya
| |