Messages in this thread | | | Date | Thu, 16 May 2013 14:25:10 -0400 | From | Dave Jones <> | Subject | Re: net: cdc_ncm, cdc_mbim: allow user to prefer NCM for backwards compatibility |
| |
Hi Bjørn,
> Gitweb: http://git.kernel.org/linus/;a=commit;h=1e8bbe6cd02fc300c88bd48244ce61ad9c7d1776 > Commit: 1e8bbe6cd02fc300c88bd48244ce61ad9c7d1776 > Parent: a5b8db91442fce9c9713fcd656c3698f1adde1d6 > Author: Bjørn Mork <bjorn@mork.no> > AuthorDate: Thu Mar 14 01:05:13 2013 +0000 > Committer: David S. Miller <davem@davemloft.net> > CommitDate: Sun Mar 17 11:59:03 2013 -0400 > > net: cdc_ncm, cdc_mbim: allow user to prefer NCM for backwards compatibility > > commit bd329e1 ("net: cdc_ncm: do not bind to NCM compatible MBIM devices") > introduced a new policy, preferring MBIM for dual NCM/MBIM functions if > the cdc_mbim driver was enabled. This caused a regression for users > wanting to use NCM. > > Devices implementing NCM backwards compatibility according to section > 3.2 of the MBIM v1.0 specification allow either NCM or MBIM on a single > USB function, using different altsettings. The cdc_ncm and cdc_mbim > drivers will both probe such functions, and must agree on a common > policy for selecting either MBIM or NCM. Until now, this policy has > been set at build time based on CONFIG_USB_NET_CDC_MBIM. > > Use a module parameter to set the system policy at runtime, allowing the > user to prefer NCM on systems with the cdc_mbim driver.
Is there any way we can set this automatically based on the type of device connected and have it just work without users needing to edit modprobe.conf ?
Since this change, we've now getting reports like https://bugzilla.redhat.com/show_bug.cgi?id=963663
Dave
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |