Messages in this thread | | | Subject | Re: [PATCH 1/4] mtd: add a new field to mtd_info{} | From | Artem Bityutskiy <> | Date | Wed, 15 May 2013 10:47:44 +0300 |
| |
On Fri, 2013-05-03 at 14:21 +0800, Huang Shijie wrote: > In order to implement the NAND boot for some Freescale's chips, such as > imx23/imx28/imx50/imx6, we use a tool (called kobs-ng) to burn the uboot > and some metadata to nand chip. And the ROM code will use the metadata to > configrate the BCH, and to find the uboot. > > The ECC information(ecc step size, ecc strength) which is used to configrate > the BCH is part of the metadata. The kobs-ng can gets the ecc strength from > the sys node /sys/*/ecc_strength now. But it can not gets the ecc step size. > > This patch adds a new field to store the ecc step size in mtd_info{}, and > it makes preparation for the next patches. > > Signed-off-by: Huang Shijie <b32955@freescale.com> > --- > include/linux/mtd/mtd.h | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h > index 183a304..b93035f 100644 > --- a/include/linux/mtd/mtd.h > +++ b/include/linux/mtd/mtd.h > @@ -173,6 +173,9 @@ struct mtd_info { > /* ECC layout structure pointer - read only! */ > struct nand_ecclayout *ecclayout; > > + /* the ecc step size. */ > + unsigned int ecc_size;
It would really be nice to harmonize the naming and probably stick to ecc_step everywhere. To me things looks confusing, because ecc_size is actually ECC step size, and not the size of ECC codes.
-- Best Regards, Artem Bityutskiy
| |