Messages in this thread | | | Date | Thu, 25 Apr 2013 10:14:54 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] x86, efi: Fix a build warning |
| |
* Matt Fleming <matt.fleming@intel.com> wrote:
> On 25/04/13 07:55, Ingo Molnar wrote: > > It's a basic cleanliness and robustness issue: we generally avoid type > > casts in the kernel, because type casts override compile-time type checks > > and are easy to get wrong. They are also ugly. > > > > So in generaly we try to use the right type for the data structure, which > > matches its usage (and standardize functions/methods around that type) - > > then no cast is needed. > > Yeah, I'm not advocating using casts, I was just saying "Oh, x86-64 > avoids requiring the caller of efi_call_phys* to perform the cast by > doing it in the definition of efi_call*. That's why this is only > affecting 32-bit." > > Cleaning this up would be nice. I think at this point, I'll apply > Borislav's patch, and fix all this casting after v3.9 is released, since > instead of just changing query_variable_info, we might as well change > everything in efi_runtime_service_t so that it's consistent.
Sounds fine to me.
Thanks,
Ingo
| |