Messages in this thread | | | Date | Thu, 25 Apr 2013 12:47:29 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH] x86, efi: Fix a build warning |
| |
On Thu, Apr 25, 2013 at 08:19:05AM +0100, Matt Fleming wrote: > Yeah, I'm not advocating using casts, I was just saying "Oh, x86-64 > avoids requiring the caller of efi_call_phys* to perform the cast > by doing it in the definition of efi_call*. That's why this is only > affecting 32-bit." > > Cleaning this up would be nice. I think at this point, I'll apply > Borislav's patch, and fix all this casting after v3.9 is released, > since instead of just changing query_variable_info, we might as well > change everything in efi_runtime_service_t so that it's consistent.
I wonder - if efi_runtime_service_t contained only void * like efi_boot_services_t then we could drop all the casts too, right? Even in the efi_call* macro calls too...
If you want me, I can take care of it after the merge window :)
-- Regards/Gruss, Boris.
Sent from a fat crate under my desk. Formatting is fine. --
| |