lkml.org 
[lkml]   [2013]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm, highmem: remove useless virtual variable in page_address_map
On Thu, Apr 25, 2013 at 03:00:57PM -0700, Andrew Morton wrote:
> On Mon, 22 Apr 2013 17:26:28 +0900 Joonsoo Kim <iamjoonsoo.kim@lge.com> wrote:
>
> > We can get virtual address without virtual field.
> > So remove it.
> >
> > ...
> >
> > --- a/mm/highmem.c
> > +++ b/mm/highmem.c
> > @@ -320,7 +320,6 @@ EXPORT_SYMBOL(kunmap_high);
> > */
> > struct page_address_map {
> > struct page *page;
> > - void *virtual;
> > struct list_head list;
> > };
> >
> > @@ -362,7 +361,10 @@ void *page_address(const struct page *page)
> >
> > list_for_each_entry(pam, &pas->lh, list) {
> > if (pam->page == page) {
> > - ret = pam->virtual;
> > + int nr;
> > +
> > + nr = pam - page_address_map;
>
> Doesn't compile. Presumably you meant page_address_maps.
>
> I'll drop this - please resend if/when it has been runtime tested.

Sorry for that.
I'll resend when it has been runtime tested.

Thanks.

>
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>


\
 
 \ /
  Last update: 2013-04-26 02:41    [W:1.743 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site