lkml.org 
[lkml]   [2013]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm, highmem: remove useless virtual variable in page_address_map
On Mon, 22 Apr 2013 17:26:28 +0900 Joonsoo Kim <iamjoonsoo.kim@lge.com> wrote:

> We can get virtual address without virtual field.
> So remove it.
>
> ...
>
> --- a/mm/highmem.c
> +++ b/mm/highmem.c
> @@ -320,7 +320,6 @@ EXPORT_SYMBOL(kunmap_high);
> */
> struct page_address_map {
> struct page *page;
> - void *virtual;
> struct list_head list;
> };
>
> @@ -362,7 +361,10 @@ void *page_address(const struct page *page)
>
> list_for_each_entry(pam, &pas->lh, list) {
> if (pam->page == page) {
> - ret = pam->virtual;
> + int nr;
> +
> + nr = pam - page_address_map;

Doesn't compile. Presumably you meant page_address_maps.

I'll drop this - please resend if/when it has been runtime tested.




\
 
 \ /
  Last update: 2013-04-26 01:01    [W:0.074 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site