lkml.org 
[lkml]   [2013]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [tip:perf/urgent] perf: Treat attr.config as u64 in perf_swevent_init()
From
Date
On Mon, 2013-04-15 at 03:42 -0700, tip-bot for Tommi Rantala wrote:
> Commit-ID: 8176cced706b5e5d15887584150764894e94e02f
> Gitweb: http://git.kernel.org/tip/8176cced706b5e5d15887584150764894e94e02f
> Author: Tommi Rantala <tt.rantala@gmail.com>
> AuthorDate: Sat, 13 Apr 2013 22:49:14 +0300
> Committer: Ingo Molnar <mingo@kernel.org>
> CommitDate: Mon, 15 Apr 2013 11:42:12 +0200
>
> perf: Treat attr.config as u64 in perf_swevent_init()
>
> Trinity discovered that we fail to check all 64 bits of
> attr.config passed by user space, resulting to out-of-bounds
> access of the perf_swevent_enabled array in
> sw_perf_event_destroy().

Gah, I so missed we could hide bits in the top word and then use them
in _destroy().

The alternative is of course to also truncate to int in _destroy(), but
yes keeping the natural size seems the best alternative.




\
 
 \ /
  Last update: 2013-04-18 14:01    [W:0.238 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site