Messages in this thread | | | Subject | Re: [tip:perf/urgent] perf: Treat attr.config as u64 in perf_swevent_init() | From | Peter Zijlstra <> | Date | Thu, 18 Apr 2013 13:17:08 +0200 |
| |
On Mon, 2013-04-15 at 03:42 -0700, tip-bot for Tommi Rantala wrote: > Commit-ID: 8176cced706b5e5d15887584150764894e94e02f > Gitweb: http://git.kernel.org/tip/8176cced706b5e5d15887584150764894e94e02f > Author: Tommi Rantala <tt.rantala@gmail.com> > AuthorDate: Sat, 13 Apr 2013 22:49:14 +0300 > Committer: Ingo Molnar <mingo@kernel.org> > CommitDate: Mon, 15 Apr 2013 11:42:12 +0200 > > perf: Treat attr.config as u64 in perf_swevent_init() > > Trinity discovered that we fail to check all 64 bits of > attr.config passed by user space, resulting to out-of-bounds > access of the perf_swevent_enabled array in > sw_perf_event_destroy().
Gah, I so missed we could hide bits in the top word and then use them in _destroy().
The alternative is of course to also truncate to int in _destroy(), but yes keeping the natural size seems the best alternative.
| |