Messages in this thread Patch in this message |  | | From | Tommi Rantala <> | | Subject | [PATCH] perf: treat attr.config as u64 in perf_swevent_init() | | Date | Sat, 13 Apr 2013 22:49:14 +0300 |
| |
Trinity discovered that we fail to check all 64 bits of attr.config passed by user space, resulting to out-of-bounds access of the perf_swevent_enabled array in sw_perf_event_destroy().
Introduced in commit b0a873ebb ("perf: Register PMU implementations").
Signed-off-by: Tommi Rantala <tt.rantala@gmail.com> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> --- kernel/events/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c index 59412d0..fff6420 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -5330,7 +5330,7 @@ static void sw_perf_event_destroy(struct perf_event *event) static int perf_swevent_init(struct perf_event *event) { - int event_id = event->attr.config; + u64 event_id = event->attr.config; if (event->attr.type != PERF_TYPE_SOFTWARE) return -ENOENT; -- 1.8.1.4
|  |