Messages in this thread | | | Date | Tue, 12 Mar 2013 15:00:37 -0400 | From | Chris Metcalf <> | Subject | Re: [PATCH 1/1] mm/hugetlb: add more arch-defined huge_pte_xxx functions |
| |
On 3/12/2013 2:48 PM, Gerald Schaefer wrote: > Commit abf09bed3c "s390/mm: implement software dirty bits" introduced > another difference in the pte layout vs. the pmd layout on s390, > thoroughly breaking the s390 support for hugetlbfs. This requires > replacing some more pte_xxx functions in mm/hugetlbfs.c with a > huge_pte_xxx version. > > This patch introduces those huge_pte_xxx functions and their > implementation on all architectures supporting hugetlbfs. This change > will be a no-op for all architectures other than s390. > > [...] > > +static inline pte_t mk_huge_pte(struct page *page, pgprot_t pgprot) > +{ > + return mk_pte(page, pgprot); > +}
Does it make sense to merge this new per-arch function with the existing per-arch arch_make_huge_pte() function? Certainly in the tile case, we could set up our "super" bit in the initial mk_huge_pte() call, and then set "young" and "huge" after that in the platform-independent caller (make_huge_pte). This would allow your change to eliminate some code as well as just introducing code :-)
-- Chris Metcalf, Tilera Corp. http://www.tilera.com
| |