Messages in this thread | | | Date | Mon, 4 Feb 2013 15:49:16 -0800 | From | Greg Kroah-Hartman <> | Subject | Re: TDM bus support in Linux Kernel [PATCH] |
| |
On Tue, Feb 05, 2013 at 10:31:21AM +1100, Ryan Mallon wrote: > On 30/01/13 23:37, Kurachkin Michail wrote: > > Hi Greg, > > > > I followed your recommendations and created a diff using Linux 3.8-rc5 sources. Please review it and give your comments. > > > > > > Hi Kurachkin, > > Below is a quick skim-through review (of about 70% of the code). I've > not really commented on the design, mostly just on coding style and > small bugs. For patch-sets of this size, can you please break them down > into multiple small patches, and please post patches inline which make > reviewing easier.
Those types of changes can all be done after the code is in the drivers/staging/ tree, and are not a barrier for acceptance at this point in time.
thanks,
greg k-h
| |