Messages in this thread | | | From | Oliver Neukum <> | Subject | Re: TDM bus support in Linux Kernel [PATCH] | Date | Tue, 05 Feb 2013 16:34:28 +0100 |
| |
On Monday 04 February 2013 16:08:58 Michail Kurachkin wrote: > Hi Oliver, > > Thank you for the code review. I am working on the sources and soon > will send you the update. > > By the way, I did not find suitable implementation of software circular buffer management. src/include/linux/circ_buf.h seems to be very limited solution. > What do you think about adding the following functions/macros to the global namespace?
Additions to the global namespace needs to be done very carefully.
> int cb_init(struct circ_buf *cb, int item_size, int count); > void cb_free(struct circ_buf *cb); > int cb_push(struct circ_buf *cb, void *item); > int cb_pop(struct circ_buf *cb, void *item);
void pointers here may be suboptimal
> int cb_is_full(struct circ_buf *cb); > int cb_is_empty(struct circ_buf *cb);
I suggest you implement them in private and if they serve you well, we can discuss making them global. The important point is that you don't duplicate code.
Regards Oliver
| |