| Date | Mon, 4 Feb 2013 16:11:29 -0500 (EST) | From | Alan Stern <> | Subject | Re: [PATCH v2 09/31] USB: ehci-omap: Use devm_ioremap_resource() |
| |
On Mon, 4 Feb 2013, Roger Quadros wrote:
> Make use of devm_ioremap_resource() and correct comment. > > CC: Alan Stern <stern@rowland.harvard.edu> > Signed-off-by: Roger Quadros <rogerq@ti.com> > --- > drivers/usb/host/ehci-omap.c | 21 ++++++--------------- > 1 files changed, 6 insertions(+), 15 deletions(-) > > diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c > index 30fc482..6b088a4 100644 > --- a/drivers/usb/host/ehci-omap.c > +++ b/drivers/usb/host/ehci-omap.c > @@ -216,23 +216,17 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev) > > res = platform_get_resource_byname(pdev, > IORESOURCE_MEM, "ehci"); > - if (!res) { > - dev_err(dev, "UHH EHCI get resource failed\n"); > - return -ENODEV; > - } > - > - regs = ioremap(res->start, resource_size(res)); > - if (!regs) { > - dev_err(dev, "UHH EHCI ioremap failed\n"); > - return -ENOMEM; > + regs = devm_ioremap_resource(dev, res); > + if (IS_ERR(regs)) { > + dev_err(dev, "Resource request/ioremap failed\n");
According to Thierry Reding, devm_ioremap_resource() provides its own error messages. Hence this one isn't needed.
Apart from this one issue,
Acked-by: Alan Stern <stern@rowland.harvard.edu>
|